Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve No valid constructors error message to suggest a list of valid constructors #10150

Merged
merged 1 commit into from Mar 30, 2020
Merged

Improve No valid constructors error message to suggest a list of valid constructors #10150

merged 1 commit into from Mar 30, 2020

Conversation

fusuiyi123
Copy link
Contributor

Pull Request Checklist

Helpful things

Fixes

Fixes #8474

Purpose

add the following message. #8474 (comment)

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?
#9501

raboof
raboof approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@mergify mergify bot merged commit 76ad96d into playframework:master Mar 30, 2020
@fusuiyi123 fusuiyi123 deleted the ISSUE-8474 branch April 14, 2020 03:10
@mkurz mkurz mentioned this pull request Apr 14, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"No valid constructors" if you only need Configuration
2 participants
@fusuiyi123 @raboof