Remove symbolic multiple param methods #10229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
reviewed
Apr 26, 2020
| override def +(e1: TypedEntry[_], e2: TypedEntry[_]): TypedMap = | ||
| new DefaultTypedMap(m + (e1.key -> e1.value) + (e2.key -> e2.value)) | ||
| override def +(e1: TypedEntry[_], e2: TypedEntry[_], e3: TypedEntry[_]): TypedMap = | ||
| new DefaultTypedMap(m + (e1.key -> e1.value) + (e2.key -> e2.value) + (e3.key -> e3.value)) | ||
| override def +(entries: TypedEntry[_]*): TypedMap = { |
There was a problem hiding this comment.
you also shouldn't have this varargs method. instead, it should take a single arg such as an IterableOnce, and it is general practice to name it ++. the same for - with varargs (should take a collection and and be called --)
|
@mkurz, I see that It's a common practice to overload the symbolic operators with named methods: |
|
Done in #11672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10221
@NthPortal I guess this is what you were talking about?