[2.7.x] Fix Json issues: parse on form and tailrec deser #10496
Conversation
| @@ -0,0 +1,186 @@ | |||
| /* | |||
| * Copyright (C) Lightbend Inc. <https://www.lightbend.com> | |||
There was a problem hiding this comment.
Today is like one of those days that you convince yourself that nothing that you know about builds is valid.
I changed that line because of this error in Travis.
Note, this is a scala file failing when running the java code formatter. Ok, before running the java formatter we run the scala formatter, so we could think that it's failing because the code was modified by the scala formatter. Well, in that case, the scala formatter should fail, no?
Moreover, I could not reproduce it locally. So, simply decided to change the offending line and pray that this thing will pass.
There was a problem hiding this comment.
One more weird thing about it, is that the failure is about a file header. Which is checked after scalafmt and javafmt.
Anyway, I can't explain that.
There was a problem hiding this comment.
The reason may be that my local branch was not rebased which surprises me because I remember to have done it. I can be mistaking.
octonato
force-pushed
the
rgc/json-fix-2.7.x
branch
from
46a34dc
to
564035a
Compare
Co-authored-by: James Roper <james@jazzy.id.au> Co-authored-by: Marcos Pereira <marcos.silva@gmail.com>
Co-authored-by: James Roper <james@jazzy.id.au> Co-authored-by: Marcos Pereira <marcos.silva@gmail.com> Co-authored-by: Johannes Rudolph <johannes.rudolph@gmail.com> Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
octonato
force-pushed
the
rgc/json-fix-2.7.x
branch
from
564035a
to
4ea9cc8
Compare
| object JacksonJsonNodeModule extends JacksonJsonNodeModule | ||
|
|
||
| private class JsonNodeDeserializer extends JsonDeserializer[JsonNode] { | ||
| override def isCachable: Boolean = true |
There was a problem hiding this comment.
Yep, this is implementing a Jackson abstract class.
No description provided.