Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ###replace: tag that led to incorrect docs #10789

Merged
merged 3 commits into from
Nov 24, 2021

Commits on Mar 29, 2021

  1. Fixed ###replace: tag that led to incorrect docs

    Docs before: https://www.playframework.com/documentation/2.8.x/PlayApplicationOverview: 
    
    ```java
    public Result index() {
           return ok(views.html.index.render("Your new application is
      return ok(javaguide.hello.html.index.render("Your new application is ready.", assetsFinder));
    }
    ```
    
    According to https://www.playframework.com/documentation/2.8.x/Documentation
    ```###replace: foo — Replace the next line with foo. You may optionally terminate this command with ###```
    
    The code sample that was to be run, tested, and injected into the documentation was split into multiple lines (likely by an autoformatter) which made the documentation for the java example incorrect. 
    
    This PR changes the 'replace' to one line, and also reduces the whitespace on the left to prevent the autoformatter from splitting the line into two.
    sss-ng committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    e3c37f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. moved comment left

    Hopefully, the comment has been moved left enough that it won't be split by the formatter. Let's see what the build says
    sss-ng committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    6a56b9b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Configuration menu
    Copy the full SHA
    0f38f39 View commit details
    Browse the repository at this point in the history