Make sure scripted jobs use the same commit like publish-local did #10855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the comment I added in the
test-scripted
file.Now that scala-steward runs monthly, it opens many pull requests at once, in parallel, increasing the chance that these pull requests fail, because of the problem I described in my comment. The problem existed before as well and pull requests failed every now and then, but I never really looked into it what the problem was, until now, when I realized what's going on.
Let's look at one of those failed pull requests: https://travis-ci.com/github/playframework/playframework/builds/225836519:
As you can see, the publish-local jobs used the version
2.8.1+1156-e905d7a5
, so the distance from the2.8.0
tag is 1156 and the current commit is e905d7a (being a merge commit GitHub provides as if the pull request already had been merged, which in reality didn't happen course). Now after that publish local but before the (failed) scripted job started one pull request (#10847) got merged. So based on the information in my comment, the master branch moved forward, and now the scripted jobs use a different version:2.8.1+1158-5a053e91
. Distance got increased by 2 (1 commit for the version update + 1 merge commit) and of course the hash changed.You can see the difference between the two master branches here: