Remove obsolete CertificateGenerator #10865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
force-pushed
the
rm_CertificateGenerator
branch
from
3810a23
to
251984f
Compare
gmethvin
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As its javadoc says it was "Used for testing only"
The specs it was used in got removed in #6681 and #8649 (see removed
FakeKeyStoreSpec.scalain that PR).Afterwards it was not used anymore.
Also its a duplicate of https://github.com/lightbend/ssl-config/blob/v0.4.3/ssl-config-core/src/test/scala/com/typesafe/sslconfig/ssl/CertificateGenerator.scala anyway.