Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring for better code readability #11074

Merged
merged 1 commit into from Jan 24, 2022

Conversation

yorlov
Copy link
Contributor

@yorlov yorlov commented Dec 25, 2021

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

@yorlov
Copy link
Contributor Author

yorlov commented Dec 27, 2021

My build failed, but I don't know why. My changes are so simple.

javafmtAll didn't do any changes

@mkurz
Copy link
Member

mkurz commented Dec 30, 2021

@yorlov for me javafmtAll worked:

/*
 * Copyright (C) Lightbend Inc. <https://www.lightbend.com>
 */

package play.core;

import java.util.Arrays;
import java.util.Collections;
import java.util.List;

public class Build {

  public static final List<String> sharedClasses =
      Collections.unmodifiableList(
          Arrays.asList(
              play.core.BuildLink.class.getName(),
              play.core.BuildDocHandler.class.getName(),
              play.core.server.ReloadableServer.class.getName(),
              play.api.UsefulException.class.getName(),
              play.api.PlayException.class.getName(),
              play.api.PlayException.InterestingLines.class.getName(),
              play.api.PlayException.RichDescription.class.getName(),
              play.api.PlayException.ExceptionSource.class.getName(),
              play.api.PlayException.ExceptionAttachment.class.getName()));
}

Can you please update the PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants