Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8.x] Upgrade Spring to fix Spring4Shell vulnerability #11214

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Mar 31, 2022

@mkurz mkurz added this to the 2.8.15 milestone Mar 31, 2022
@mkurz mkurz merged commit a898ec0 into playframework:2.8.x Mar 31, 2022
@mkurz mkurz deleted the fix_Spring4Shell branch March 31, 2022 12:56
@ProChirathF
Copy link

We have other dependencies pulling Spring 5.3.18, do we know if Play 2.8.15 is compatible with Spring 5.3.x or would you recommend us to force 5.2.20

@mkurz
Copy link
Member Author

mkurz commented Apr 7, 2022

Hey Chirath, we can easily test this by temporary upgrading to 5.3.x in the 2.8.x branch. Here is the pull request: #10819
If all tests turn green it should be pretty safe to use 5.3.18 in your project:
https://app.travis-ci.com/github/playframework/playframework/builds/249075661
The test coverage for the spring databinder is very high, we have many tests for that in Play.

@mkurz
Copy link
Member Author

mkurz commented Apr 7, 2022

(Updated the last comment with the now correct link the travis: https://app.travis-ci.com/github/playframework/playframework/builds/249075661)

@mkurz
Copy link
Member Author

mkurz commented Apr 7, 2022

@ProChirathF The build with Spring 5.3.18 didn't fail, so I would assume it's safe to use those dependencies with Play 2.8.15: https://app.travis-ci.com/github/playframework/playframework/builds/249075661 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants