sbt-header plugins should handle md files in docs project #11245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Apr 19, 2022
| FileType("md") -> CommentStyle(new CommentCreator() { | ||
| override def apply(text: String, existingText: Option[String]): String = { | ||
| s"<!--- $text -->" | ||
| } |
There was a problem hiding this comment.
I opened sbt/sbt-header#285 to simplify the CommentStyle config even more.
|
Merging, all doc related tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the ancient
addMarkdownCopyrightscript obsolete so we can remove it in #11142, since we have the sbt-header plugin now.The empty line gets added by default when running
headerCreateAll. We could setheaderEmptyLine := false, however that does not really help, since there are many java and scala files which do have the empty line, meaning now these would be modified, this time automatically removing the empty line by the sbt-header plugin.