Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix play/libs/Files.java. prepare Scala 3 #11308

Merged
merged 1 commit into from Jun 4, 2022

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jun 3, 2022

Pull Request Checklist

Helpful things

Fixes

fix compile error in Scala 3.

Purpose

use TemporaryFileCreator type instead of SingletonTemporaryFileCreator$

Background Context

A.scala

package example

trait A

object B extends A

C.java

package example;

public class C {
  example.B$ b = example.B$.MODULE$;
}

compile with Scala 3.1.2

[error] 4 |  example.B$ b = example.B$.MODULE$;
[error]   |  ^^^^^^^^^^
[error]   |  type B is not a member of example - did you mean example.B.type?
[error] one error found
[error] (Compile / compileIncremental) Compilation failed

References

@ihostage ihostage added this to the 2.9.0 milestone Jun 3, 2022
@mergify mergify bot merged commit 7c147a9 into playframework:main Jun 4, 2022
@xuwei-k xuwei-k deleted the patch-2 branch June 6, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants