New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use `CollectionConverters` instead of deprecated `JavaConverters` #11322

Merged

gmethvin merged 1 commit into playframework:main from xuwei-k:javaapi-CollectionConverters

Jun 13, 2022

Contributor

xuwei-k commented Jun 10, 2022

Pull Request Checklist

Have you read How to write the perfect pull request?
Have you read through the contributor guidelines?
Have you signed the Lightbend CLA?
Have you referenced any issues you're fixing using commit message keywords?
Have you added copyright headers to new files?
Have you checked that both Scala and Java APIs are updated?
Have you updated the documentation for both Scala and Java sections?
Have you added tests for any changed functionality?

Helpful things

Fixes

Fix warnings

Purpose

Background Context

Drop Scala 2.12 and sbt 1.3 (and 0.13.x leftovers) #10956 play dropped Scala 2.12 support

References


          use CollectionConverters instead of deprecated JavaConverters

5bfc3dc

xuwei-k marked this pull request as ready for review

June 10, 2022 22:41

gmethvin approved these changes

View reviewed changes

gmethvin merged commit 6e614d1 into playframework:main

xuwei-k deleted the javaapi-CollectionConverters branch

June 13, 2022 02:22

ihostage added this to the 2.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment