New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scala-java8-compat dependency #11334

Merged

octonato merged 1 commit into playframework:main from xuwei-k:java8-compat

Jun 16, 2022

Contributor

xuwei-k commented Jun 16, 2022

Pull Request Checklist

Have you read How to write the perfect pull request?
Have you read through the contributor guidelines?
Have you signed the Lightbend CLA?
Have you referenced any issues you're fixing using commit message keywords?
Have you added copyright headers to new files?
Have you checked that both Scala and Java APIs are updated?
Have you updated the documentation for both Scala and Java sections?
Have you added tests for any changed functionality?

Helpful things

Fixes

Purpose

use std scala.jdk. classes instead of scala-java8-compat library.

Background Context

playframework dropped Scala 2.12 Drop Scala 2.12 and sbt 1.3 (and 0.13.x leftovers) #10956
https://github.com/scala/scala/blob/2.13.x/src/library/scala/jdk/ scala std lib has some converters since Scala 2.13

References


          remove scala-java8-compat dependency

8914ca1

xuwei-k marked this pull request as ready for review

June 16, 2022 03:23

octonato approved these changes

View reviewed changes

Contributor

octonato left a comment

LGTM

octonato merged commit 429f95e into playframework:main

xuwei-k deleted the java8-compat branch

June 16, 2022 07:42

ihostage added this to the 2.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment