Fixing SLF4J 2.0.0 issue for #11419 and #11400 #11433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not entirely sure what's wrong here, however, just to make sure I just cleaned the GitHub actions cache and re-run the tests. |
|
@mkurz well, it did the job. Well done! |
|
😉 I don't know the last days cleaning the cache resolved some problems... Anyway thanks! |
mkurz
reviewed
Sep 21, 2022
| @@ -75,8 +76,7 @@ object Dependencies { | |||
| ) | |||
|
|
|||
| val jdbcDeps = Seq( | |||
| ("com.zaxxer" % "HikariCP" % "4.0.3") | |||
| .exclude("org.slf4j", "slf4j-api"), // fetches slf4j 2.0.0-alpha1, but Play (still) uses 1.7, see https://github.com/brettwooldridge/HikariCP/pull/1669 | |||
benwaffle
pushed a commit
to flowcommerce/lib-util
that referenced
this pull request
Sep 22, 2022
While slf4j 2.x is backwards compatible, Play framework does not have a release that supports slf4j 2.x yet. The [fix](playframework/playframework#11433) has been merged, and should be out in Play 2.8.17.
benwaffle
pushed a commit
to flowcommerce/lib-util
that referenced
this pull request
Sep 22, 2022
While slf4j 2.x is backwards compatible, Play framework does not have a release that supports slf4j 2.x yet. The [fix](playframework/playframework#11433) has been merged, and should be out in Play 2.8.17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Resolves #11419 and resolves #11400
Purpose
Upgrading SLF4J to v2.0.0 forces us to upgrade Logback too, as explained on the Logback documentation.
We can't upgrade Logback to 1.4.1 as it needs at least Java 11, and we must keep the Java 8 compatibility for now.
Also removing an exluded dependency for HikariCP as it depends also on SLF4J 2.0.0.
Has been tested on Java 8 and Java 11.
References
Should fix PR #11417