Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate <dependencyManagement /> tag in BOM #11449

Merged
merged 1 commit into from Oct 3, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Oct 3, 2022

Publishing a first experimental milestone for the next Play major version didn't work.

So, the BillOfMaterialsPlugin plugin appends the dependency listings to pomExtra. Unfortunaly, until now, we did the same as well., so the entries were duplicated.
Until now however this didn't cause any problems, because interplay "hard reseted" pomExtra, so it kind of overrode one of those settings. Since last interplay release however it does not set pomExtra anymore, so now both settings kick in, creating the duplicates.
(This problem did not materialize in Play 2.8.x because it uses an old version of interplay).

I also think publishTo shouldn't be set here because the sbt-ci-release plugin already handles that.

@mkurz
Copy link
Member Author

mkurz commented Oct 3, 2022

Not necessary to wait for tests, but I want to see the snaphot that gets published.

@mkurz mkurz merged commit ad020ac into playframework:main Oct 3, 2022
@mkurz mkurz deleted the fix_bom branch October 3, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant