Override getOrElseUpdate to set expiration based on value #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
force-pushed
the
getOrElseUpdate_override
branch
2 times, most recently
from
cca4be7
to
1cc13d4
Compare
mkurz
force-pushed
the
getOrElseUpdate_override
branch
from
1cc13d4
to
81467af
Compare
|
Rebased onto #11516 |
mkurz
force-pushed
the
getOrElseUpdate_override
branch
from
81467af
to
9c1a22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, don't review yet.
Allows more flexibility. IMHO there are cases when it makes sense to set the expiration date based on the "new" value that was just calculated. Makes it possible to fix #11506 (I am not saying there are no other ways to fix that problem, even if so this pull request on it's on does make some sense IMHO)