Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8.x] Fix missed ContextInitializer#configureByResource (backport #11910) by @tsuyoshizawa #11915

Merged
merged 2 commits into from Aug 12, 2023
Merged

[2.8.x] Fix missed ContextInitializer#configureByResource (backport #11910) by @tsuyoshizawa #11915

merged 2 commits into from Aug 12, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 12, 2023 •
edited by mkurz

This is an automatic backport of pull request #11910 done by Mergify.

@mergify mergify bot added the conflicts label Aug 12, 2023
@mergify mergify bot mentioned this pull request Aug 12, 2023
Merged
7 tasks
@mkurz mkurz added this to the 2.8.21 milestone Aug 12, 2023
tsuyoshizawa and others added 2 commits August 12, 2023 17:48
@tsuyoshizawa @mkurz
ported configureByResource from logback
2767f53 
(cherry picked from commit d0bf4cf)

# Conflicts:
#	core/play-logback/src/main/scala/play/api/libs/logback/LogbackLoggerConfigurator.scala
@mkurz
Comments
333f81e 
(cherry picked from commit 65df970)
@mkurz
Copy link
Member

mkurz commented Aug 12, 2023

Turns out DefaultJoranConfigurator was introduced in logback 1.3.0, but Play 2.8.x still depends on 1.2.x, so we need to use the initial suggested copy/paste approach here.

@mergify mergify bot merged commit 947c195 into 2.8.x Aug 12, 2023
24 checks passed
@mergify mergify bot deleted the mergify/bp/2.8.x/pr-11910 branch August 12, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkurz @tsuyoshizawa