fix warnings with Scala 3.4. avoid private[this]

[xuwei-k]

Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you referenced any issues you're fixing using commit message keywords?
• Have you added copyright headers to new files?
• Have you checked that both Scala and Java APIs are updated?
• Have you updated the documentation for both Scala and Java sections?
• Have you added tests for any changed functionality?

Helpful things

Fixes

Purpose

fix warnings. use private instead of private[this] in routes-compiler generate code.

Background Context

• Deprecation warnings for old syntax: private[this] scala/scala3#18819
• https://docs.scala-lang.org/scala3/reference/dropped-features/this-qualifier.html

References

[ahjohannessen]

@mkurz Can this be merged?

[mkurz]

Since all tests pass it seems this doesn't do any harm (and we have quite a lot of tests regarding routing, specially also scripted tests). Probably a leftover from old days.

[mkurz]

@Mergifyio backport 2.9.x

[mergify]

backport 2.9.x

✅ Backports have been created

• #12364 [2.9.x] fix warnings with Scala 3.4. avoid private[this] (backport #12284) by @xuwei-k has been created for branch 2.9.x

[ahjohannessen]

@mkurz Would be nice with a minor release with this :)

[mkurz]

@mkurz Would be nice with a minor release with this :)

This will be in the next patch release even, however I don't have a rush just because of this pull request, because we do not officially support non-LTS Scala releases. Just be patient 😉