Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuzminki added to ModuleDirectory.md #12502

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

karimagnusson
Copy link
Contributor

I added links to the documentation and demo pages for my project Kuzminki.

Pull Request Checklist

  • [x ] Have you read How to write the perfect pull request?
  • [ x] Have you read through the contributor guidelines?
  • [x ] Have you referenced any issues you're fixing using commit message keywords?
  • [ x] Have you added copyright headers to new files?
  • [ x] Have you checked that both Scala and Java APIs are updated?
  • [x ] Have you updated the documentation for both Scala and Java sections?
  • [x ] Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

Why did you take this approach?

References

Are there any relevant issues / PRs / mailing lists discussions?

I added links to the documentation and demo pages for my project Kuzminki.
Entry for io-path added.
@mkurz
Copy link
Member

mkurz commented Apr 8, 2024

@karimagnusson Do these modules also support Play 2.9?

@karimagnusson
Copy link
Contributor Author

@karimagnusson Do these modules also support Play 2.9?

Yes, both modules have support for 2.9, but in both cases support 2.9 is an older version of the module. I have updated the readme pages to make this clear.

As I understand it, most users have switched to version 3. I can of course update the versions for 2.9 if there is interest.

@mkurz
Copy link
Member

mkurz commented Apr 8, 2024

As I understand it, most users have switched to version 3. I can of course update the versions for 2.9 if there is interest.

I would just wait for user feedback 😉

@mkurz mkurz merged commit 0a35304 into playframework:main Apr 8, 2024
29 checks passed
@mkurz
Copy link
Member

mkurz commented Apr 8, 2024

@Mergifyio backport 2.9.x

@mkurz
Copy link
Member

mkurz commented Apr 8, 2024

@Mergifyio backport 3.0.x

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport 2.9.x

✅ Backports have been created

Copy link
Contributor

mergify bot commented Apr 8, 2024

backport 3.0.x

✅ Backports have been created

mkurz added a commit that referenced this pull request Apr 8, 2024
[2.9.x] Kuzminki added to ModuleDirectory.md (backport #12502) by @karimagnusson
mkurz added a commit that referenced this pull request Apr 8, 2024
[3.0.x] Kuzminki added to ModuleDirectory.md (backport #12502) by @karimagnusson
@karimagnusson
Copy link
Contributor Author

Do you know when these changes will appear on playframework.com?

@karimagnusson karimagnusson deleted the patch-1 branch April 10, 2024 06:20
@mkurz
Copy link
Member

mkurz commented Apr 10, 2024

Do you know when these changes will appear on playframework.com?

With the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants