sbt-native-packager 1.10.0 (improves Scala 3 support) #12527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be totally safe to ship with next 3.0.x and 2.9.x patch releases: |
|
@Mergifyio backport 3.0.x |
✅ Backports have been created
|
|
@Mergifyio backport 2.9.x |
✅ Backports have been created
|
This comment was marked as off-topic.
This comment was marked as off-topic.
See sbt-native-packager#1592
mkurz
commented
Apr 12, 2024
| @@ -25,7 +25,7 @@ checkStartScript := { | |||
| } | |||
| val contents = IO.read(startScript) | |||
| val lines = IO.readLines(startScript) | |||
| if (!contents.contains("app_mainclass=(play.core.server.ProdServerStart)")) { | |||
| if (!contents.contains("app_mainclass=('play.core.server.ProdServerStart')")) { | |||
There was a problem hiding this comment.
Because of sbt/sbt-native-packager@cb29893
Actually that fix improves Scala 3 support
This was referenced Apr 12, 2024
Merged
mkurz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was helping out yesterday and today in the sbt-native-packager repo to get a new release out (the first since 14 month)....