Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPY button in document code section would move along with the scroll bar #12294 #12533

Closed
wants to merge 2 commits into from

Conversation

pckrishnadas88
Copy link
Contributor

@pckrishnadas88 pckrishnadas88 commented Apr 14, 2024

Purpose

To fix the issue COPY button in document code section would move along with the scroll bar

Background Context

The clipboard.min.js and it's code snippet was missing when tested locally in manual.scala.html. So that is added from live and modified. Scrolling issue is fixed. If main file must be included in a different way you may modify that.

References

[Are there any relevant issues / PRs / mailing lists

Refer to this video for the current fix.

1080video.mp4

@mkurz
Copy link
Member

mkurz commented Apr 15, 2024

@pckrishnadas88 Thanks! However we do not need to include the clipboard js file here in the main repository. It comes from https://github.com/playframework/playframework.com/ - this is the repo which basically gets deployed on playframework.com and it also renders the documentation from this repo. These files here provide the clipboard functioniallty:

What did you actually change that the clipboard button does not move anymore?
We probably need to apply this fix in the https://github.com/playframework/playframework.com repo.

@mkurz
Copy link
Member

mkurz commented Apr 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants