Fully documented the Java Functional helpers #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Could you please sign our CLA? http://www.typesafe.com/contribute/cla ? |
|
Signed. |
pk11
pushed a commit
that referenced
this pull request
Apr 11, 2012
Fully documented the Java Functional helpers
|
thank you. |
| return Some(function.apply(get())); | ||
| } catch (RuntimeException e) { | ||
| throw e; | ||
| } catch (Throwable t) { | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
Aren't we losing the original exception (throwable) here?
There was a problem hiding this comment.
Wow, I didn't even notice that, you are right.
There was a problem hiding this comment.
Pull request with fix:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this pull request is just javadocs. However, there are a few other small changes: