Fully documented the Java Functional helpers #224

Merged
merged 2 commits into from Apr 11, 2012

Conversation

Projects
None yet
3 participants
Owner

jroper commented Apr 6, 2012

Most of this pull request is just javadocs. However, there are a few other small changes:

  • The biggest one is that everywhere that wraps throwables in RuntimeExceptions has been modified so that RuntimeExceptions don't get double wrapped. This should mean if talking to libraries that throw RuntimeException subclasses, that things like get() should end up throwing the original exception that was thrown, instead of throwing a wrapped (possibly many times) exception.
  • A few function parameters have been renamed for the purposes of better documenting them.
Collaborator

pk11 commented Apr 11, 2012

This looks good. Could you please sign our CLA? http://www.typesafe.com/contribute/cla ?

Owner

jroper commented Apr 11, 2012

Signed.

pk11 added a commit that referenced this pull request Apr 11, 2012

Merge pull request #224 from vznet/jroper/f-javadocs
Fully documented the Java Functional helpers

@pk11 pk11 merged commit a2fa280 into playframework:master Apr 11, 2012

Collaborator

pk11 commented Apr 11, 2012

thank you.

+ return Some(function.apply(get()));
+ } catch (RuntimeException e) {
+ throw e;
+ } catch (Throwable t) {
throw new RuntimeException();
@aukevanleeuwen

aukevanleeuwen Apr 19, 2012

Aren't we losing the original exception (throwable) here?

@jroper

jroper Apr 19, 2012

Owner

Wow, I didn't even notice that, you are right.

@jroper

jroper Apr 19, 2012

Owner

Pull request with fix:

playframework#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment