Simplify PlayReloader by removing unused code #2681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanted to see if anyone would have a chance to look at this. Wanted to make a couple other changes, but wanted to check that this one was okay first |
|
Hi Ben I've been away but will try to get to this today. |
|
Thanks @huntc ! |
|
So given that there's no automated testing around this, can you please explain how you've arrived at the solution and how you've tested it? Thanks Ben. |
|
oops. nevermind. i thought that there was automated testing of this, so was overconfident in this change and didn't look at it close enough. i can see what it's doing now and this change doesn't work, so i'm going to close this PR. thanks @huntc ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there's some code here which is unused and removing it has no effect