Assets controller sends constant etag if path has a space in the name #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request attached. Interestingly, I scanned back through the code history, this bug has existed for as long as last modified has been used to generate the etag - over 3 years. |
pvlugter
added a commit
that referenced
this pull request
Dec 8, 2014
Assets controller sends constant etag if path has a space in the name
ClaraAllende
pushed a commit
to ClaraAllende/playframework
that referenced
this pull request
Aug 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX 10.9 (and probably everywhere else).
If the application is running under a path with a space in the name, then the code that gets the last modified date for an asset fails to find the file, and returns 0 (epoch). In dev mode, since the etag is a digest of last modified, this means the asset etag is always constant, which means even after changing an asset, Play will always return 304 not modified.
The effect is that changes to assets are never reflected in the browser.