Removed usage of stream.available for stream size (it is the entire size in some implementations but it is not guaranteed) #4481
Conversation
mrydzy
commented
May 18, 2015
•
mrydzy
commented
| @@ -475,6 +489,18 @@ class AssetsBuilder(errorHandler: HttpErrorHandler) extends Controller { | |||
| } | |||
| } | |||
|
|
|||
| def getResult(file: String, assetInfo: AssetInfo, connection: URLConnection, gzipRequested: Boolean): Result = { | |||
There was a problem hiding this comment.
Make this private, also perhaps rename to createResult.
|
We should probably have some tests that assert the content length is right - they can be added to Also, would be good to test both the file case and the jar case. All the existing tests there, in practice, are testing the file case. You'll need to come up with a resource that can be served from a jar off the classpath. This may best be achieved by creating a custom |
* Checking file size for JarUrlConnection and FileUrlConnection
* Sending chuncked response otherwise
mrydzy
force-pushed
the
wip/feature/streams
branch
from
1cc4751
to
442c681
Compare
|
I'm not sure if I understood why to create custom URLClassLoader. |
|
@mrydzy are you still interested in getting this change in? if so, it would be helpful to rebase the PR and add some tests |
|
closing due to lack of activity |
