Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom template docs reflect new Twirl API #4811

Merged
merged 1 commit into from Dec 9, 2015
Merged

Make custom template docs reflect new Twirl API #4811

merged 1 commit into from Dec 9, 2015

Conversation

themillhousegroup
Copy link

Play version 2.3.x and 2.4.x use more complicated versions of the Twirl BufferedContent[A] and Format[T] than were documented here. The examples based on Html have been updated to be in line with the latest tagged Twirl API, 1.0.4.

Play version 2.3.x and 2.4.x use more complicated versions of the Twirl BufferedContent[A] and Format[T] than were documented here. The examples based on Html have been updated to be in line with the latest tagged Twirl API, 1.0.4.
@gmethvin
Copy link
Member

gmethvin commented Jul 7, 2015

This would be a great place to convert the markdown code sample to a compiled code sample, so we don't run into this issue again.

@themillhousegroup
Copy link
Author

Agreed - I'll fix that up.

@benmccann
Copy link
Contributor

@themillhousegroup I wanted to check if you still planned to convert to a compiled code sample before we merge this? thanks for the contribution!

@themillhousegroup
Copy link
Author

Hi,
Thanks for reminding me, I do still plan on doing this but haven't had the
time recently.

Regards,
John

On Sun, Sep 6, 2015 at 3:40 AM, Ben McCann notifications@github.com wrote:

@themillhousegroup https://github.com/themillhousegroup I wanted to
check if you still planned to convert to a compiled code sample before we
merge this? thanks for the contribution!


Reply to this email directly or view it on GitHub
#4811 (comment)
.

@benmccann
Copy link
Contributor

I'm going to go ahead and merge this since it seems like a good change. We can and should convert to a compiled code sample at some point

benmccann added a commit that referenced this pull request Dec 9, 2015
Make custom template docs reflect new Twirl API
@benmccann benmccann merged commit 7877d9c into playframework:2.3.x Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants