allow i18n usage on weblogic (play 2.4) #5763
Conversation
svalaskevicius
changed the title
svalaskevicius
changed the title
svalaskevicius
changed the title
|
@svalaskevicius Tests fail for this pull request: |
|
oh wow, it looks like everything has exploded.. but tests worked locally, and the same change is passing on master #5764.. I'll force push something to get it rebuilt and see if it helps |
when a play app is deployed as a war on weblogic, it fails as the classpath contains zip archives and isDirectory throws an Exception, rendering the usage of I18n unusable. Based on 422ca97.
svalaskevicius
force-pushed
the
2.4/fix-i18n-on-weblogic
branch
from
48abfe5
to
0b5fe10
Compare
|
@svalaskevicius Tests still fails with the same error. Please check the error here: |
|
yeah, saw it, checking locally again, this is a bit confusing given that the same change works well on 2.3 and 2.5 versions :) |
|
OK - It looks like it is not your fault. #5612 just failed with the same error. Looks like the 2.4. branch is broken... |
|
Ok. Thanks for checking! |
|
Re: the failing build -- I suspect something is up with Travis's CI environment. Restarting... |
|
The 2.4.x branch seems to be stable again. Merging. |
Pull Request Checklist
Purpose
Allow I18n usage of play 2.4 apps on weblogic.
Background Context
Loading of I18n messages checks if items on the classpath are directories and breaks the application on unknown protocol e.g. "zip", which exists on weblogic installations.
References
Original commit introducing the breakage - 686a9b4
Fix for 2.3 branch - 422ca97 (PR #5728)