Fix displaying runtime exception coming from Twirl template while running in development mode - PR for branch 2.4.x #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error while running in dev mode.
Merged
|
@gslowikowski Test fail, please check. |
|
Strange. Failing test is NingConfigSpec in play-ws module. It has nothing to do with my change and it works for me locally. Can you rerun the Travis build? Maybe it's something random. |
|
I already restarted the test twice. |
|
Are the tests working locally on your machine? |
|
Yes |
|
@gslowikowski and @mkurz tests for 2.4.x branches are more unstable than expected. I've fired another build at travis and if it did not pass, I can run the tests locally to check that this patch is good. WDYT? |
|
It works for me locally. Does anybody else test it? |
cchantep
approved these changes
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6190 for
2.4.xbranch