Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: clarify how the child actor get its name #6693

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Projects
None yet
3 participants
@rethab
Copy link
Contributor

commented Nov 3, 2016

Pull Request Checklist

  • Have you read How to write the perfect pull request?
  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you [squashed your commits]? (Optional, but makes merge messages nicer.)
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Helpful things

Fixes

Fixes #xxxx

Purpose

What does this PR do?

Background Context

It adds a tiny bit to the akka documentation clarifying how the child actor gets its name, because in the existing example the key parameter is used both as a parameter to the factory as well as the actor's name.

References

Are there any relevant issues / PRs / mailing lists discussions?

  • this confused me a lot when I saw that the key is passed twice.
documentation: clarify how the child actor get its name
  - this confused me a lot when I saw that the key is passed twice.

@gmethvin gmethvin merged commit 12d02be into playframework:master Nov 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

gmethvin added a commit that referenced this pull request Nov 3, 2016

documentation: clarify how the child actor get its name (#6693)
- this confused me a lot when I saw that the key is passed twice.

@mkurz mkurz added this to the 2.5.10 milestone Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.