Keep headers when Content-Encoding set #7930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richdougherty
commented
Oct 15, 2017
| @@ -13,7 +13,7 @@ private[server] object HttpRequestDecoder { | |||
|
|
|||
| private def decodeRequestWith(decoderFlow: Flow[ByteString, ByteString, NotUsed], request: HttpRequest): HttpRequest = { | |||
| request.withEntity(request.entity.transformDataBytes(decoderFlow)) | |||
| .withHeaders(request.headers.filter(_.isInstanceOf[`Content-Encoding`])) | |||
| .withHeaders(request.headers.filter(!_.isInstanceOf[`Content-Encoding`])) | |||
There was a problem hiding this comment.
Here's the problem! The condition needs to negated, otherwise we strip out the wrong headers.
Fixes playframework#7911. The code now filters out the Content-Encoding header instead of all the other headers when decoding the request content.
richdougherty
force-pushed
the
content-encoding-headers
branch
from
0005112
to
2069dd2
Compare
|
Updated - |
gmethvin
approved these changes
Oct 18, 2017
gmethvin
pushed a commit
that referenced
this pull request
Oct 18, 2017
Fixes #7911. The code now filters out the Content-Encoding header instead of all the other headers when decoding the request content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7911.
The code now filters out the Content-Encoding header instead of all the other headers when decoding the request content.