Fix LogbackLoggerConfigurator#init #8378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmethvin
commented
Apr 23, 2018
| @@ -63,6 +66,7 @@ class LogbackLoggerConfigurator extends LoggerConfigurator { | |||
|
|
|||
| val properties = LoggerConfigurator.generateProperties(env, configuration, optionalProperties) | |||
|
|
|||
| play.api.Logger.setApplicationMode(env.mode) | |||
There was a problem hiding this comment.
This actually fixes a separate bug. The mode should be set in configure not init since init is only called by the dev mode server and not the application itself.
gmethvin
force-pushed
the
logback-init
branch
2 times, most recently
from
9bfb8e6
to
9dc8168
Compare
gmethvin
changed the title
gmethvin
changed the title
marcospereira
approved these changes
Apr 27, 2018
gmethvin
added a commit
that referenced
this pull request
Apr 27, 2018
gmethvin
added a commit
that referenced
this pull request
Apr 27, 2018
marcospereira
added
the
status:ready-to-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed this in #8275 without realizing this was only used in initializing the dev mode server before an application is available, and is intentionally more minimal for that reason. This change should be minimal risk, since it reverts to the previous behavior in 2.6.12.
This also fixes another issue, which is that the global logging mode (used for
logger.forMode) should be set inconfigure.