Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aakash06/add type annotation #8630

Merged
merged 2 commits into from Sep 25, 2018
Merged

Aakash06/add type annotation #8630

merged 2 commits into from Sep 25, 2018

Conversation

Aakash06
Copy link

@Aakash06 Aakash06 commented Sep 24, 2018 •
edited

  1. Added the type annotation for Scala's Play Framework Default Error Handler methods.
    I think they are necessary during documentation to tell the learner what's their return type.

Pull Request Checklist

Purpose

What does this PR do?
It will provide type annotation for methods in the documentation.

marcospereira
marcospereira approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Merge after a green build.

@gmethvin gmethvin merged commit 4fbd844 into playframework:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospereira marcospereira marcospereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aakash06 @marcospereira @gmethvin