Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logger documentation and add Logging trait #8816

Merged
merged 2 commits into from Nov 20, 2018

Conversation

gmethvin
Copy link
Member

  • Updates Logger documentation to de-emphasize the global logger and mention that it is now deprecated.
  • Clarifies different migration paths in the migration guide.
  • Updates example code to use a locally-defined logger val where possible.
  • Adds a Logging trait to make it much easier to use a logger per class in Scala.

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just added small enhancements

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for following up so fast, @gmethvin!

@dwijnand dwijnand merged commit 6d629e4 into playframework:master Nov 20, 2018
@gmethvin gmethvin deleted the logger branch November 20, 2018 22:23
octonato pushed a commit that referenced this pull request Nov 21, 2018
 - Updates Logger documentation to de-emphasize the global logger and mention that it is now deprecated.
 - Clarifies different migration paths in the migration guide.
 - Updates example code to use a locally-defined logger val where possible.
 - Adds a `Logging` trait to make it much easier to use a logger per class in Scala.
@dwijnand dwijnand added this to the Play 2.8.0-M1 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants