New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not promote artifacts automatically #8846

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
4 participants
@marcospereira
Member

marcospereira commented Nov 29, 2018

Purpose

Our release process right now publishes to two services: Sonatype (that will sync to Maven Central) and Bintray (where sbt plugins) lives. That means if one of the services fails for some reason, we may end up in a situation where the release is half done. When that happens, the most secure thing is to do another release increasing the version number.

But this is not ideal and may lead to a confusing situation. For example, right now we have two release candidates for Play 2.7.0 but the second one is RC8!

Not promoting the artifacts automatically is not ideal since it adds manual steps to our release process, but for now, it helps us to avoid this situation where we have half-baked releases. We will eventually refactor our release process to make it safer and with minimal manual intervention.

@dwijnand dwijnand merged commit e7f5191 into playframework:master Nov 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@marcospereira marcospereira deleted the marcospereira:do-not-auto-promote-artifacts branch Dec 4, 2018

marcospereira added a commit that referenced this pull request Dec 4, 2018

@marcospereira

This comment has been minimized.

Member

marcospereira commented Dec 4, 2018

Backport to 2.7.x: 754a0cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment