Do not promote artifacts automatically #8846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
approved these changes
Nov 29, 2018
ignasi35
approved these changes
Nov 29, 2018
|
Backport to 2.7.x: 754a0cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Our release process right now publishes to two services: Sonatype (that will sync to Maven Central) and Bintray (where sbt plugins) lives. That means if one of the services fails for some reason, we may end up in a situation where the release is half done. When that happens, the most secure thing is to do another release increasing the version number.
But this is not ideal and may lead to a confusing situation. For example, right now we have two release candidates for Play 2.7.0 but the second one is RC8!
Not promoting the artifacts automatically is not ideal since it adds manual steps to our release process, but for now, it helps us to avoid this situation where we have half-baked releases. We will eventually refactor our release process to make it safer and with minimal manual intervention.