fix jmh Microbenchmarks #8990
Merged
fix jmh Microbenchmarks #8990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Thank you, @jtjeferreira. Is it possible to configure our script to get these problems? https://github.com/playframework/playframework/blob/master/framework/bin/validate-microbenchmarks |
I dont have a lot of experience with sbt-jmh, so we should investigate how to make the "test" fail instead of being a success... If that is not possible we would have to parse the console output? |
|
hey @marcospereira, found a solution! see 80ed1fc (that should fail) |
|
and now I pushed the fix to the tests... 82e1972 |
gmethvin
approved these changes
Feb 5, 2019
|
2.7.x 985ee6a |
dwijnand
pushed a commit
that referenced
this pull request
Mar 12, 2019
# Pull Request Checklist * [X] Have you read [How to write the perfect pull request](https://github.com/blog/1943-how-to-write-the-perfect-pull-request)? * [X] Have you read through the [contributor guidelines](https://www.playframework.com/contributing)? * [X] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)? * [ ] Have you referenced any issues you're fixing using [commit message keywords](https://help.github.com/articles/closing-issues-using-keywords/)? * [X] Have you added copyright headers to new files? * [X] Have you checked that both Scala and Java APIs are updated? * [X] Have you updated the documentation for both Scala and Java sections? * [X] Have you added tests for any changed functionality? # Helpful things ## Purpose Fixes `p.microbenchmark.it.HelloWorldBenchmark` when using akka-http-2 (ak-20-enc) and akka http1.1 encrypted (ak-11-enc) ## Background Context `ak-20-enc` was failing with a `java.lang.ClassNotFoundException: akka.http.scaladsl.Http2` exception because of missing akka-http2-support jar. `ak-11-enc` was failing with a `javax.net.ssl.SSLPeerUnverifiedException: Hostname localhost not verified:` which was solved by setting the a dumb `hostnameVerifier` in the OkHttp client (cherry picked from commit 524aa8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Purpose
Fixes
p.microbenchmark.it.HelloWorldBenchmarkwhen using akka-http-2 (ak-20-enc) and akka http1.1 encrypted (ak-11-enc)Background Context
ak-20-encwas failing with ajava.lang.ClassNotFoundException: akka.http.scaladsl.Http2exception because of missing akka-http2-support jar.ak-11-encwas failing with ajavax.net.ssl.SSLPeerUnverifiedException: Hostname localhost not verified:which was solved by setting the a dumbhostnameVerifierin the OkHttp client