Remove application.secret and play.crypto.secret support #9061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed playframework#8981 playframework#8981 Removed `play.crypto.secret` & `application.secret` leaving `play.http.secret.key` as the only way to set secret key
marcospereira
changed the title
There was a problem hiding this comment.
Thanks a lot, @chipz.
See my comment. After that, I think this will be good to merge. :-)
| } | ||
|
|
||
| } | ||
|
|
||
| trait SecretConfigurationParserSpec extends Specification { |
There was a problem hiding this comment.
We can change this trait to be a class and use play.http.secret.key as the secretKey value. And then remove ActualKeySecretConfigurationParserSpec as well. :-)
There was a problem hiding this comment.
thanks for the review. done.
mkurz
reviewed
Feb 22, 2019
| @@ -285,7 +285,7 @@ object HttpConfiguration { | |||
| val Blank = """\s*""".r | |||
|
|
|||
| val secret = | |||
| config.getDeprecated[Option[String]]("play.http.secret.key", "play.crypto.secret", "application.secret") match { | |||
| config.getDeprecated[Option[String]]("play.http.secret.key") match { | |||
There was a problem hiding this comment.
You can just use get here now instead of getDeprecated
…nfigurationParserSpec from trait to class - Changed getDeprecated to get as we removed deprecated code
marcospereira
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #8981
Purpose
Removed
play.crypto.secret&application.secretleavingplay.http.secret.keyas the only way to set secret key