Use Jackson ObjectMapper provided by Akka #9494
Conversation
core/play-integration-test/src/it/scala/play/it/libs/json/JavaJsonSpec.scala
Show resolved
Hide resolved
core/play-java/src/main/scala/play/core/ObjectMapperModule.scala
Outdated
Show resolved
Hide resolved
| ``` | ||
|
|
||
| ### Custom binding for `ObjectMapper` |
There was a problem hiding this comment.
Still valid and possibly simpler than customizing JacksonObjectMapperProvider from Akka, at least from a Play user perspective. But most of the need to do it can be reduced if Akka supports MapperFeatures and others.
I will start a conversation about it with Akka Team.
Including WRITE_NUMBERS_AS_STRINGS that is changing from true to false
documentation/manual/releases/release28/migration28/Migration28.md
Outdated
Show resolved
Hide resolved
|
@marcospereira, I approved it but added the block-merge because of minor change request. Feel free to remove the label when CR addressed. |
…8.md Co-Authored-By: Renato Cavalcanti <renato@cavalcanti.be>
|
Thanks, @renatocaval. Accept your changes and also did some last revision to improve the text. |
|
Resolved merge conflict, your turn Travis! |
|
|
||
| "ObjectMapper" should { | ||
| "respect the custom configuration" in new JsonScope { | ||
| Json.mapper().isEnabled(SerializationFeature.WRITE_DATES_WITH_ZONE_ID) must beFalse |
There was a problem hiding this comment.
This test is wrong. It tests for WRITE_DATES_WITH_ZONE_ID but WRITE_DURATIONS_AS_TIMESTAMPS is configured. Makes no sense. No matter if I set WRITE_DURATIONS_AS_TIMESTAMPS to true or false (like here) the test always passes...
Fixes
Fixes #9383.
Status
ObjectMapperbased on the name (as supported by Akka)