Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt 1.3.6 and fix coursier cache #9967

Merged
merged 1 commit into from Jan 6, 2020

Conversation

octonato
Copy link
Member

@octonato octonato commented Jan 6, 2020

No description provided.

@mergify mergify bot merged commit 72c8fa5 into playframework:2.8.x Jan 6, 2020
@octonato octonato deleted the fix-coursier-cache branch January 6, 2020 12:23
@@ -128,7 +128,7 @@ jobs:

cache:
directories:
- "$HOME/.coursier/cache"
- "$HOME/.cache/coursier"
Copy link
Member

@mkurz mkurz Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @renatocaval, just wondering why you changed that. Are you sure $HOME/.cache/coursier is correct? Just checked with latest sbt 1.3.7, on my Ubuntu installation, coursier still uses ~/.coursier/cache/.
There are discussions about coursier's and sbt's cache locations (coursier/coursier#1483, sbt/sbt#3681), but nothing got merged yet (coursier/coursier#1484).
Or did I miss something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coursier uses ~/.coursier/cache if it's present, otherwise it uses ~/.cache/coursier on Linux, ~/Library/<something> on macOS, and something Windows-appropriate on Windows (i.e. platform-specific and platform-conforming directories).

coursier/coursier#1483 is about following XDG (Linux's standard) on all platform, ignoring what macOS and Windows platform observe, for the benefit of having the same path on any platform. But it does mention the ~/.coursier/cache vs ~/.cache/coursier (on Linux) backwards-compatible shim, and how it adds to an already complicated story (and so it should be removed).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for your explanation @dwijnand

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I guess this behaviour was introduced after sbt 1.3.0, because as far as I remember I never used coursier before it got introduced with sbt 1.3.0 and therefore no ~/.coursier folder existed yet on my machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it got added to Coursier a few years ago, so I'm not too sure why/how/when it appeared on your box... Maybe sbt made integrated Coursier support wrong at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants