ScalaTest 3.2 #353

cheeseng · 2022-04-18T14:11:58Z

Updated to use ScalaTest 3.2.13.
Dropped PhantomJS support.
Added support for new MS Edge browser support.

…s support.

…erSuite and AllBrowsersPerTest to def.

…-play into feature-scalatest-3.2

.gitignore

mkurz · 2022-04-28T09:41:43Z

build.sbt

@@ -102,17 +101,23 @@ lazy val `scalatestplus-play` = project
    mimaSettings,
    organization := "org.scalatestplus.play",
    libraryDependencies ++= Seq(
+      // Note: It seems like the only jackson version that works with all play, play-ws, play-json and selenium is 2.11.4.
+      //       play will bring in older version of selenium as well, so need excluding and let scalatest+selenium brings in the newer version.4


If I remember correctly, this is because new selenium versions do not support Java 8 anymore, but right now Play still is build with Java 8.
However we are going to drop Java 8 very soon, so that would resolve that problem.

project/plugins.sbt

cheeseng · 2022-04-28T15:11:19Z

@mkurz I just pushed a quick commit according to your comments, do you mind to see if it is fit for merging now?

Thanks!

…-play into feature-scalatest-3.2

cheeseng · 2022-05-25T14:40:42Z

@mkurz I have resolved the conflict and upgraded to use scalatest+selenium 3.2.12.1, which includes a new support for MS Edge browser, do you mind to review and consider merging this when it is convenient for you?

Thanks!

mkurz · 2022-05-25T14:41:36Z

@cheeseng Sure I will, I was a bit busy the last days, I will be back working on Play soon. Stay tuned.

…-play into feature-scalatest-3.2

cheeseng · 2022-07-09T09:34:45Z

@mkurz Ping! I have resolved the conflict and this PR is ready for your review again. Thanks!

mkurz · 2022-07-11T10:12:16Z

Thanks @cheeseng! I want to set up GitHub actions before merging this pull request (actually, this is the last repo in the Play organization missing GHA) to make sure this change passes all the tests.

cheeseng · 2022-07-13T14:42:09Z

@mkurz That's a good idea, I am adding CI build in scalatest+selenium (one of the dependency here) and it seems to work:

scalatest/scalatestplus-selenium#20

But when I added the same ci.yml here it failed with this weird error:

[error] Failed to derive version from git tags. Maybe run `git fetch --unshallow`? Version: 0.0.0+1-1e104898

I am not familiar with this, may be it is related to sbt-dynver?

cheeseng · 2022-07-13T15:00:56Z

@mkurz By the way I think the current main is broken now? When I tried to build it I got the following error:

cheeseng@cheeseng-RAVEN:~/git/scalatestplus-play$ sbt clean test
[info] welcome to sbt 1.7.1 (GraalVM Community Java 1.8.0_302)
[info] loading global plugins from /home/cheeseng/.sbt/1.0/plugins
[info] loading settings for project scalatestplus-play-build from plugins.sbt ...
[info] loading project definition from /home/cheeseng/git/scalatestplus-play/project
/home/cheeseng/git/scalatestplus-play/build.sbt:35: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
ThisBuild / resolvers += Resolver.sonatypeRepo("releases")
                                  ^
[info] loading settings for project scalatestplus-play-root from build.sbt ...
[info] set current project to scalatestplus-play-root (in build file:/home/cheeseng/git/scalatestplus-play/)
[success] Total time: 0 s, completed Jul 13, 2022 10:58:49 PM
[info] Updating 
[info] Resolved  dependencies
[warn] 
[warn] 	Note: Unresolved dependencies path:
[error] sbt.librarymanagement.ResolveException: Error downloading org.scalatestplus:selenium-4-1_2.13:3.1.4.0
[error]   Not found
[error]   Not found
[error]   not found: /home/cheeseng/.ivy2/local/org.scalatestplus/selenium-4-1_2.13/3.1.4.0/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/service/local/repositories/releases/content/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://repo.artima.com/releases/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: /home/cheeseng/.m2/repository/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/orgscalactic-1457/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/orgscalatest-1753/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error] 	at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:345)
[error] 	at lmcoursier.CoursierDependencyResolution.$anonfun$update$38(CoursierDependencyResolution.scala:314)
[error] 	at scala.util.Either$LeftProjection.map(Either.scala:573)
[error] 	at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:314)
[error] 	at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
[error] 	at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:59)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:133)
[error] 	at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:73)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:146)
[error] 	at scala.util.control.Exception$Catch.apply(Exception.scala:228)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:146)
[error] 	at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:127)
[error] 	at sbt.util.Tracked$.$anonfun$inputChangedW$1(Tracked.scala:219)
[error] 	at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:160)
[error] 	at sbt.Classpaths$.$anonfun$updateTask0$1(Defaults.scala:3688)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] 	at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] 	at sbt.Execute.work(Execute.scala:291)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] 	at java.lang.Thread.run(Thread.java:748)
[error] (scalatestplus-play / update) sbt.librarymanagement.ResolveException: Error downloading org.scalatestplus:selenium-4-1_2.13:3.1.4.0
[error]   Not found
[error]   Not found
[error]   not found: /home/cheeseng/.ivy2/local/org.scalatestplus/selenium-4-1_2.13/3.1.4.0/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/service/local/repositories/releases/content/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://repo.artima.com/releases/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: /home/cheeseng/.m2/repository/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/orgscalactic-1457/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error]   not found: https://oss.sonatype.org/content/repositories/orgscalatest-1753/org/scalatestplus/selenium-4-1_2.13/3.1.4.0/selenium-4-1_2.13-3.1.4.0.pom
[error] Total time: 10 s, completed Jul 13, 2022 10:59:00 PM

cheeseng · 2022-07-14T14:12:36Z

@mkurz I have added ci.yml that will run CI, here's the successfully run for this PR:

https://github.com/playframework/scalatestplus-play/runs/7341113874?check_suite_focus=true

Cheers.

….0 and mockito 4.6.1.

cheeseng · 2022-08-01T13:55:05Z

@mkurz Ping again! I have updated the PR to use the newly released ScalaTest 3.2.13, the CI tests run that included in this PR seems to be green also:

https://github.com/playframework/scalatestplus-play/runs/7604177607?check_suite_focus=true

Cheers.

cheeseng · 2022-09-01T13:06:55Z

@mkurz Ping again! I have updated the PR to use selenium 4.4.0 and htmlunit 3.64.0, and the CI build is green.

mkurz · 2022-09-06T10:07:28Z

@cheeseng Thanks again, fantastic! I will have a look asap 👍

…-play into feature-scalatest-3.2

…eServerPerSuiteWithOneBrowserPerTestSpec to prevent test failure flickerig.

cheeseng · 2022-09-17T04:02:47Z

@mkurz Ping again! I fixed the conflict and added some fix to avoid flickering of test failures, the CI passed also, do you mind to look at this again?

Thanks.

.github/workflows/ci.yml

mkurz · 2022-09-21T13:47:54Z

@cheeseng Sorry not being responsive here, I want to dedicate time tomorrow for this issue.

cheeseng · 2022-09-21T14:35:07Z

@mkurz No worry at all, will be looking forward to tomorrow! :)

For the sharable workflow, may I suggest that we address it in a separate PR? As it is quite different from the main intent for this PR.

Cheers.

cheeseng added 5 commits April 15, 2022 22:44

First version that works with ScalaTest 3.2.10, had to drop phantom j…

f0b67d3

…s support.

Got the tests to go green when run in Firefox and Chrome.

9eafdb5

Changed firefoxProfile, chromeOptions, firefoxProfile in AllBrowsersP…

938fb51

…erSuite and AllBrowsersPerTest to def.

Merge branch 'main' of https://github.com/playframework/scalatestplus…

483ba2c

…-play into feature-scalatest-3.2

Updated to use ScalaTest 3.2.12.

dc882ee

mkurz requested changes Apr 28, 2022

View reviewed changes

Adjusted according to @mkurz's comments.

de6946c

cheeseng added 3 commits May 25, 2022 11:35

Merge branch 'main' of https://github.com/playframework/scalatestplus…

a725191

…-play into feature-scalatest-3.2

Updated to use scalatest+selenium 3.2.12.1.

1d1c55d

Added support for the newly added Edge browser.

6f3d2de

Merge branch 'main' of https://github.com/playframework/scalatestplus…

cb0da65

…-play into feature-scalatest-3.2

cheeseng requested a review from mkurz July 9, 2022 09:34

Trying to add ci.yml.

ebd1b6f

Added git fetch --unshallow to ci.yml.

0a73c3b

cheeseng mentioned this pull request Jul 14, 2022

[DO-NOT-MERGE] Test CI Build #366

Closed

Updated version of scalatest to 3.2.13, selenium 4.2.2, htmlunit 3.62…

d5f1b21

….0 and mockito 4.6.1.

This was referenced Aug 18, 2022

scalatest 3.2.13 (was 3.1.4) #367

Closed

htmlunit-driver 2.63.0 (was 2.62.0) #368

Closed

selenium-java 4.3.0 (was 4.1.4) #369

Closed

Bumped selenium version up to 4.4.0, and htmlunit version to 3.64.0.

c3ca97e

cheeseng added 2 commits September 17, 2022 11:27

Merge branch 'main' of https://github.com/playframework/scalatestplus…

80c20ee

…-play into feature-scalatest-3.2

Added IntegrationPatient to MixedFixturesWsScalaTestClientSpec and On…

0a38abc

…eServerPerSuiteWithOneBrowserPerTestSpec to prevent test failure flickerig.

ihostage reviewed Sep 19, 2022

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

mkurz added 2 commits October 6, 2022 11:02

Merge branch 'main' into feature-scalatest-3.2

16ffbec

Key not needed anymore

ad9dfda

mkurz mentioned this pull request Oct 6, 2022

update scalatest dependencies. remove deprecated phantomjs #337

Closed

mkurz merged commit ad9dfda into playframework:main Oct 7, 2022

ihostage mentioned this pull request Jul 3, 2023

Aborted tests not reported in JUnit XML reporter - support scalatest 3.2.x #430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ScalaTest 3.2 #353

ScalaTest 3.2 #353

cheeseng commented Apr 18, 2022 •

edited

Loading

mkurz Apr 28, 2022

cheeseng commented Apr 28, 2022

cheeseng commented May 25, 2022

mkurz commented May 25, 2022

cheeseng commented Jul 9, 2022

mkurz commented Jul 11, 2022

cheeseng commented Jul 13, 2022

cheeseng commented Jul 13, 2022

cheeseng commented Jul 14, 2022

cheeseng commented Aug 1, 2022

cheeseng commented Sep 1, 2022

mkurz commented Sep 6, 2022

cheeseng commented Sep 17, 2022

mkurz commented Sep 21, 2022

cheeseng commented Sep 21, 2022

ScalaTest 3.2 #353

ScalaTest 3.2 #353

Conversation

cheeseng commented Apr 18, 2022 • edited Loading

mkurz Apr 28, 2022

Choose a reason for hiding this comment

cheeseng commented Apr 28, 2022

cheeseng commented May 25, 2022

mkurz commented May 25, 2022

cheeseng commented Jul 9, 2022

mkurz commented Jul 11, 2022

cheeseng commented Jul 13, 2022

cheeseng commented Jul 13, 2022

cheeseng commented Jul 14, 2022

cheeseng commented Aug 1, 2022

cheeseng commented Sep 1, 2022

mkurz commented Sep 6, 2022

cheeseng commented Sep 17, 2022

mkurz commented Sep 21, 2022

cheeseng commented Sep 21, 2022

cheeseng commented Apr 18, 2022 •

edited

Loading