Glossary #23
Merged
Glossary #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! |
|
👍 I'll have a look at this at lunch |
| ... [term](glossary://term) ... | ||
| ``` | ||
|
|
||
| Only the link to the term must be URL encoded. For example, the term "reuse identifier" would be defined in the yaml as `reuse identifier` but linked to as `glossary://reuse%20identifier`. |
There was a problem hiding this comment.
does this lint for these constraints?
There was a problem hiding this comment.
Good point, do you think the renderer should warn on this, or would that be best left to the linter?
There was a problem hiding this comment.
depends on your opinion on the workflow, would you work with say guard where it would lint on save? If so then a warning would be good
|
Cool, only nitpicks, nothing seems blocking |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18.
This is a work-in-progress because I haven't had a chance to test it with Swift Playgrounds to make sure it works. It's a bit messy, might be a better way to do this in Ruby. I'll check out to see if it works next week.