fix: Support custom expect objects created with expect.configure

Fixes #150
playwright-community · Jun 27, 2023 · 73e4d06 · 73e4d06
1 parent e7b108d
commit 73e4d06
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/utils/ast.ts b/src/utils/ast.ts
@@ -123,7 +123,7 @@ export type ExpectType = 'poll' | 'soft' | 'standalone';
 export function getExpectType(
   node: ESTree.CallExpression
 ): ExpectType | undefined {
-  if (isIdentifier(node.callee, 'expect')) {
+  if (isIdentifier(node.callee, /^expect|Expect$/)) {
     return 'standalone';
   }
 

diff --git a/test/spec/missing-playwright-await.spec.ts b/test/spec/missing-playwright-await.spec.ts
@@ -139,6 +139,31 @@ runRuleTester('missing-playwright-await', rule, {
       ],
       output: test('await expect[`poll`](() => foo)[`toBeTruthy`]()'),
     },
+    // expect.configure
+    {
+      code: dedent`
+        test('test', async () => {
+          const softExpect = expect.configure({ soft: true })
+          softExpect(foo).toBeChecked()
+        })
+     `,
+      errors: [
+        {
+          column: 3,
+          endColumn: 13,
+          endLine: 3,
+          line: 3,
+          messageId: 'expect',
+        },
+      ],
+      only: true,
+      output: dedent`
+        test('test', async () => {
+          const softExpect = expect.configure({ soft: true })
+          await softExpect(foo).toBeChecked()
+        })
+     `,
+    },
     // test.step
     {
       code: test("test.step('foo', async () => {})"),