Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: WaitForRequest/WaitForResponse accepts Options args #292

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

ninadingole
Copy link
Collaborator

@ninadingole ninadingole commented Sep 6, 2022

Resolves #124

@ninadingole ninadingole changed the title [WIP] chore: WaitForRequest accepts PageWaitForRequestOptions args chore: WaitForRequest accepts PageWaitForRequestOptions args Sep 7, 2022
@ninadingole ninadingole changed the title chore: WaitForRequest accepts PageWaitForRequestOptions args chore: WaitForRequest/WaitForResponse accepts Options args Sep 7, 2022
@ninadingole
Copy link
Collaborator Author

Not able to merge on my own, could you please @mxschmitt merge this :) thank you!
Screenshot 2022-09-22 at 5 52 47 PM

@mxschmitt mxschmitt merged commit 7f5cccf into playwright-community:main Oct 12, 2022
@ninadingole ninadingole deleted the patch/issue-124 branch October 17, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageWaitForRequestOptions and PageWaitForResponseOptions are not used anywhere
2 participants