Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options object to NodeS7 function constructor #7

Merged
merged 4 commits into from
Jun 20, 2016
Merged

Add options object to NodeS7 function constructor #7

merged 4 commits into from
Jun 20, 2016

Conversation

gfcittolin
Copy link
Collaborator

  • Added an option to the NodeS7 constructor, with the options:
    • silentMode: mutes all logging
    • debug: sets effectiveDebugLevel to 99
  • Added a Changelog

Hopefully you find it an improvement meanwhile we don't modularize/refactor the code as in discussed in #3

@gfcittolin
Merge pull request #1 from plcpeople/master
13c5146 
Rebase to plcpeople/nodes7@0.1.6
@gfcittolin
Squashed commit of the following:
cf32314 
commit 1a53bc1
Author: Guilherme Francescon Cittolin <gfcittolin@gmail.com>
Date:   Wed Jun 1 12:03:11 2016 +0200

    Added CHANGELOG.md
    Add options to NodeS7 function
    Add silent and debug mode option

# Conflicts:
#	package.json
@gfcittolin
Squashed commit of the following:
e37a15d 
commit 1a53bc1
Author: Guilherme Francescon Cittolin <gfcittolin@gmail.com>
Date:   Wed Jun 1 12:03:11 2016 +0200

    Added CHANGELOG.md
    Add options to NodeS7 function
    Add silent and debug mode option

# Conflicts:
#	package.json
@gfcittolin
Merge branch 'master' of github.com:netsmarttech/nodeS7
c06c56c 
# Conflicts:
#	CHANGELOG.md
@plcpeople
Copy link
Owner

Thank you...

@plcpeople plcpeople merged commit 279c2a5 into plcpeople:master Jun 20, 2016
@gfcittolin
Copy link
Collaborator Author

gfcittolin commented Jun 21, 2016 •
edited

My pleasure :)

BTW: You may want to take a look at node-red-contrib-s7, that is based on your awesome work with this module!

@gfcittolin gfcittolin mentioned this pull request Oct 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gfcittolin @plcpeople