Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Drivers): check auhorization before accepting files #251

Merged
merged 3 commits into from
Aug 13, 2017

Conversation

NoNameProvided
Copy link
Member

@NoNameProvided NoNameProvided commented Aug 13, 2017

This PR fixes #250.

Until now files where accepted before checking the authorization rights. Now both the Koa driver and Express driver correctly check the authorization first.

closes #250

Copy link
Contributor

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@NoNameProvided NoNameProvided merged commit ed63979 into master Aug 13, 2017
@NoNameProvided NoNameProvided deleted the fix/fileupload-auth branch August 13, 2017 16:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@UploadedFile works before @Authorized
2 participants