Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

The formula error message should be clearer #319

Closed
z4cki opened this issue Jul 8, 2022 · 5 comments
Closed

The formula error message should be clearer #319

z4cki opened this issue Jul 8, 2022 · 5 comments
Assignees
@toadfanszz
Labels
bug Something isn't working formula Related to the formula module no-issue-activity stale issue

Comments

@z4cki
Copy link
Contributor

z4cki commented Jul 8, 2022 •
edited
Loading

Describe the bug

The formula error message should be clearer, e.g. it should read: only letters or underscores can be entered
image
@z4cki z4cki added bug Something isn't working formula Related to the formula module labels Jul 8, 2022
@stackia
Copy link
Contributor

stackia commented Jul 11, 2022

@clszzyh I think you can list all possible errors in a discussion thread and let our designers discuss together.

@toadfanszz
Copy link
Contributor

@stackia I will add i18n feature to formula and move all error messages to locales/formula.en-US.yml. We can discuss on it.

See #340

@toadfanszz toadfanszz mentioned this issue Jul 11, 2022
Merged
toadfanszz pushed a commit that referenced this issue Jul 12, 2022
feat(formula): introduce i18n (#341)
234b729 
* ref #340 
* ref #319 

1. Put some of the most commonly used magic error message into i18n.
2. Add testCase for each item.
@toadfanszz
Copy link
Contributor

See https://github.com/mashcard/mashcard/blob/main/apps/server-monolith/config/locales/formula.en-US.yml
(Continuously updating.)

This was referenced Jul 18, 2022
Merged
Merged
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.

@github-actions github-actions bot added the no-issue-activity stale issue label Aug 12, 2022
@github-actions
Copy link
Contributor

This issue has been closed because it has not received response from the issue author.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@toadfanszz toadfanszz

Labels
bug Something isn't working formula Related to the formula module no-issue-activity stale issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stackia @z4cki @toadfanszz