This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
toadfanszz
commented
Jul 11, 2022
•
edited
Loading
edited
- fix Introduce basic i18n to Formula #340
- ref The formula error message should be clearer #319
- Put some of the most commonly used magic error message into i18n.
- Add testCase for each item.
This pull request has been built and is available for preview at pr341.mashcard.dev. Devtools |
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
+ Coverage 65.20% 65.25% +0.04%
==========================================
Files 789 793 +4
Lines 13948 13967 +19
Branches 2396 2395 -1
==========================================
+ Hits 9095 9114 +19
+ Misses 4552 4551 -1
- Partials 301 302 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stackia
suggested changes
Jul 12, 2022
stackia
reviewed
Jul 12, 2022
stackia
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.