Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

feat(formula): introduce i18n #341

Merged
merged 8 commits into from
Jul 12, 2022
Merged

feat(formula): introduce i18n #341

merged 8 commits into from
Jul 12, 2022

Conversation

toadfanszz
Copy link
Contributor

@toadfanszz toadfanszz commented Jul 11, 2022

  1. Put some of the most commonly used magic error message into i18n.
  2. Add testCase for each item.

@toadfanszz toadfanszz temporarily deployed to pr_preview July 11, 2022 15:34 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr341.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 02:39 Inactive
@toadfanszz toadfanszz changed the title feat(formula): add i18n feat(formula): introduce i18n Jul 12, 2022
@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 03:45 Inactive
@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 03:53 Inactive
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #341 (74488fe) into main (3d3c10e) will increase coverage by 0.04%.
The diff coverage is 92.50%.

❗ Current head 74488fe differs from pull request most recent head 92c0e99. Consider uploading reports for the commit 92c0e99 to get more accurate results

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   65.20%   65.25%   +0.04%     
==========================================
  Files         789      793       +4     
  Lines       13948    13967      +19     
  Branches     2396     2395       -1     
==========================================
+ Hits         9095     9114      +19     
+ Misses       4552     4551       -1     
- Partials      301      302       +1     
Flag Coverage Δ
frontend-unit 65.25% <92.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/formula/src/controls/column.ts 91.37% <ø> (ø)
packages/formula/src/controls/row.ts 73.33% <ø> (ø)
packages/formula/src/grammar/core.ts 89.26% <ø> (ø)
packages/formula/src/grammar/operations/access.ts 100.00% <ø> (ø)
...ackages/formula/src/grammar/operations/addition.ts 85.71% <ø> (ø)
packages/formula/src/grammar/operations/array.ts 83.33% <ø> (ø)
packages/formula/src/grammar/operations/block.ts 69.23% <ø> (ø)
packages/formula/src/grammar/operations/chain.ts 83.33% <ø> (ø)
packages/formula/src/grammar/operations/combine.ts 80.00% <ø> (ø)
...ges/formula/src/grammar/operations/equalCompare.ts 80.00% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3c10e...92c0e99. Read the comment docs.

@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 04:05 Inactive
@toadfanszz toadfanszz marked this pull request as ready for review July 12, 2022 04:07
@toadfanszz toadfanszz enabled auto-merge (squash) July 12, 2022 04:07
@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 05:56 Inactive
@toadfanszz toadfanszz requested a review from stackia July 12, 2022 06:10
@toadfanszz toadfanszz requested a review from stackia July 12, 2022 06:27
@toadfanszz toadfanszz temporarily deployed to pr_preview July 12, 2022 06:30 Inactive
@toadfanszz toadfanszz merged commit 234b729 into main Jul 12, 2022
@toadfanszz toadfanszz deleted the formula-i18n branch July 12, 2022 06:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce basic i18n to Formula
2 participants