Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

shortcut "Enter" can not save the comment #326

Closed
z4cki opened this issue Jul 8, 2022 · 1 comment · Fixed by #503 or #516
Closed

shortcut "Enter" can not save the comment #326

z4cki opened this issue Jul 8, 2022 · 1 comment · Fixed by #503 or #516
Assignees
@Darmody
Labels
bug Something isn't working richtext Related to the rich text editor module

Comments

@z4cki
Copy link
Contributor

z4cki commented Jul 8, 2022

Describe the bug

shortcut "Enter" can not save the comment

To Reproduce

  1. create a comment
  2. typing anything
  3. keyup "Enter" can not save comment

Expected behavior

No response

Additional context

No response

Logs/tracebacks

No response
@z4cki z4cki added the bug Something isn't working label Jul 8, 2022
@stackia stackia added the richtext Related to the rich text editor module label Jul 21, 2022
Darmody added a commit that referenced this issue Aug 2, 2022
@Darmody
feat(comment-editor): sends comment when pressing Enter
3e044bf 
resolve #326

Press 'Enter' t osend comment.
Press 'Shift-Enter' to add new line.
@Darmody Darmody mentioned this issue Aug 2, 2022
Merged
stackia pushed a commit that referenced this issue Aug 2, 2022
@Darmody
Fix comment editor (#503)
c2987d3 
* fix(comment-editor): fixes comment input style

* feat(comment-editor): sends comment when pressing Enter

resolve #326

Press 'Enter' t osend comment.
Press 'Shift-Enter' to add new line.
@z4cki
Copy link
Contributor Author

z4cki commented Aug 8, 2022

https://www.loom.com/share/33783a2dfbc44206a9283dcada1b9373
only can add the first comment, the second one can not be saved @Darmody

@z4cki z4cki reopened this Aug 8, 2022
Darmody added a commit that referenced this issue Aug 9, 2022
@Darmody
fix(editor): makes pressing Enter to send comment correctly
45de905 
fix #326
@Darmody Darmody mentioned this issue Aug 9, 2022
Merged
Darmody added a commit that referenced this issue Aug 9, 2022
@Darmody
fix(editor): makes pressing Enter to send comment correctly
48c1e8a 
fix #326
stackia pushed a commit that referenced this issue Aug 10, 2022
@Darmody
fix(editor): makes pressing Enter to send comment correctly (#516)
c0aea5b 
fix #326
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Darmody Darmody

Labels
bug Something isn't working richtext Related to the rich text editor module
Projects
None yet
Milestone
No milestone
3 participants
@stackia @Darmody @z4cki