Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Fix comment editor #503

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Fix comment editor #503

merged 2 commits into from
Aug 2, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Aug 2, 2022

resolve #326

Press 'Enter' to send the comment.
Press 'Shift-Enter' to add a new line.

resolve #326

Press 'Enter' t osend comment.
Press 'Shift-Enter' to add new line.
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ca65a56). Click here to learn what that means.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage        ?   69.34%           
=======================================
  Files           ?     1071           
  Lines           ?    18422           
  Branches        ?     2575           
=======================================
  Hits            ?    12775           
  Misses          ?     5332           
  Partials        ?      315           
Flag Coverage Δ
frontend-unit 65.12% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/editorViews/Discussion/Comment.tsx 93.54% <ø> (ø)
...r/src/editors/commentEditor/commentEditor.style.ts 100.00% <ø> (ø)
...ditor/src/extensions/extensions/comment/comment.ts 41.17% <41.17%> (ø)
...editor/src/editors/commentEditor/commentEditor.tsx 93.54% <91.66%> (ø)
.../Discussion/Conversation/useConversationEffects.ts 95.45% <100.00%> (ø)
...itor/src/editors/commentEditor/useCommentEditor.ts 71.42% <100.00%> (ø)
...y-editor/src/extensions/extensions/comment/meta.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca65a56...3e044bf. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

This pull request has been built and is available for preview at pr503.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@stackia stackia merged commit c2987d3 into main Aug 2, 2022
@stackia stackia deleted the fix-comment-editor branch August 2, 2022 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortcut "Enter" can not save the comment
2 participants