This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
refactor(legacy-editor): improve react renderer for node view #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of createPortal, createRoot for each node view
|
This pull request has been built and is available for preview at pr457.mashcard.dev. Devtools |
|
Improve rendering by #461 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we render all node views through
createPortal, we have to update the state to rerender the editor container component. This makes us have to handle React 18 async render issue with Prosemirror.To make it easy, instead of creating portals in the root component, create the root for each node view.