Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor(legacy-editor): improve node view portal rendering #461

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 22, 2022

Use createPortal magic third argument key to make portal rendering efficient.

@Darmody Darmody requested a review from toadfansx as a code owner July 22, 2022 11:40
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #461 (330ca67) into main (8a01c97) will increase coverage by 0.14%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   69.66%   69.81%   +0.14%     
==========================================
  Files        1060     1062       +2     
  Lines       18027    18094      +67     
  Branches     2496     2513      +17     
==========================================
+ Hits        12559    12632      +73     
+ Misses       5155     5151       -4     
+ Partials      313      311       -2     
Flag Coverage Δ
frontend-unit 65.51% <76.92%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/NodePortal/useNodePortals.ts 100.00% <ø> (ø)
...legacy-editor/src/tiptapRefactor/EditorContent.tsx 75.00% <70.00%> (ø)
...ages/editor/src/NodePortal/NodePortalContainer.tsx 100.00% <100.00%> (ø)
...legacy-editor/src/tiptapRefactor/ReactRenderer.tsx 67.85% <100.00%> (+1.19%) ⬆️
...ents/blockViews/Spreadsheet/SpreadsheetContext.tsx 21.00% <0.00%> (-2.14%) ⬇️
...ts/blockViews/Spreadsheet/useFormulaSpreadsheet.ts 80.00% <0.00%> (-0.65%) ⬇️
...omponents/blockViews/Spreadsheet/useSpreadsheet.ts 30.40% <0.00%> (-0.44%) ⬇️
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 10.38% <0.00%> (-0.14%) ⬇️
packages/formula/src/controls/spreadsheet.ts 71.51% <0.00%> (ø)
packages/formula/src/tests/feature/event/index.ts 100.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a01c97...330ca67. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr461.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@Darmody Darmody enabled auto-merge (squash) July 22, 2022 12:07
@Darmody Darmody merged commit 229a3ce into main Jul 22, 2022
@Darmody Darmody deleted the fix-portal-rendering branch July 22, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants