Skip to content
This repository has been archived by the owner on Nov 26, 2022. It is now read-only.

OAM Editor: Incorrect maximum value for the Tile Offset numeric field. #19

Closed
MetLob opened this issue Sep 25, 2015 · 2 comments
Closed

OAM Editor: Incorrect maximum value for the Tile Offset numeric field. #19

MetLob opened this issue Sep 25, 2015 · 2 comments
Labels
bug images plugin
Milestone
Version 0.9.1

Comments

@MetLob
Copy link
Contributor

MetLob commented Sep 25, 2015

  1. Maximum value of OAM.tile_offset is 0x3FF;
  2. You using the OAM.tile_offset as global tile index to tiles data. And adding tilePos (in NCER plugin) to OAM.tile_offset.
  3. Maximum value of the "Tile Offset" numeric field on the OAMEditor control is 0x3FF.

Then you should make free Maximum value of the "Tile Offset" numeric field.
Or!!!
Don't adding tilePos to OAM.tile_offset and correct supported Partitions of tiles data (see issue #18)
@MetLob MetLob mentioned this issue Sep 25, 2015
Closed
@pleonex
Copy link
Owner

pleonex commented Oct 6, 2015

I will check that.

@MetLob MetLob mentioned this issue Oct 8, 2015
Merged
pleonex added a commit that referenced this issue Feb 28, 2016
@pleonex
Merge pull request #21 from MetLob/master
97e7186 
Pull Request for issues #18, #19, #7, #8
@pleonex
Copy link
Owner

pleonex commented Feb 28, 2016

Fixed in #21 by @MetLob

@pleonex pleonex closed this as completed Feb 28, 2016
@pleonex pleonex added this to the Version 0.9.1 milestone Feb 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug images plugin
Projects
None yet
Milestone
Version 0.9.1
Development

No branches or pull requests
2 participants
@pleonex @MetLob